ensure textboxes and searchboxes do not clash, fix legend item deletion, fix legend throwing error

lightweight_charts/abstract.py

@@ -471,10 +471,15 @@ class Line(SeriesCommon):
         """
         self._chart._lines.remove(self) if self in self._chart._lines else None
         self.run_script(f'''
+            {self.id}legendItem = {self._chart.id}.legend._lines.find((line) => line.series == {self.id}.series)
+            {self._chart.id}.legend._lines = {self._chart.id}.legend._lines.filter((item) => item != {self.id}legendItem)
+
+            if ({self.id}legendItem) {{
+                {self._chart.id}.legend.div.removeChild({self.id}legendItem.row)
+            }}
+
             {self._chart.id}.chart.removeSeries({self.id}.series)
-            {self._chart.id}.legend.lines.forEach(line => {{
+            delete {self.id}legendItem
-                if (line.line === {self.id}) {self._chart.id}.legend.div.removeChild(line.row)
-            }})
             delete {self.id}
         ''')
 
@@ -506,10 +511,15 @@ class Histogram(SeriesCommon):
         Irreversibly deletes the histogram.
         """
         self.run_script(f'''
+            {self.id}legendItem = {self._chart.id}.legend._lines.find((line) => line.series == {self.id}.series)
+            {self._chart.id}.legend._lines = {self._chart.id}.legend._lines.filter((item) => item != {self.id}legendItem)
+
+            if ({self.id}legendItem) {{
+                {self._chart.id}.legend.div.removeChild({self.id}legendItem.row)
+            }}
+            
             {self._chart.id}.chart.removeSeries({self.id}.series)
-            {self._chart.id}.legend.lines.forEach(line => {{
+            delete {self.id}legendItem
-                if (line.line === {self.id}) {self._chart.id}.legend.div.removeChild(line.row)
-            }})
             delete {self.id}
         ''')
 

src/general/global-params.ts

@@ -1,6 +1,7 @@
 export interface GlobalParams extends Window {
     pane: paneStyle;    // TODO shouldnt need this cause of css variables
     handlerInFocus: string;
+    textBoxFocused: boolean;
     callbackFunction: Function;
     containerDiv: HTMLElement;
     setCursor: Function;
@@ -41,6 +42,7 @@ export function globalParamInit() {
         document.body.style.cursor = window.cursor;
     }
     window.cursor = 'default';
+    window.textBoxFocused = false;
 }
 
 export const setCursor = (type: string | undefined) => {

src/general/handler.ts

@@ -308,7 +308,7 @@ export class Handler {
         chart.div.appendChild(searchWindow);
 
         chart.commandFunctions.push((event: KeyboardEvent) => {
-            if (window.handlerInFocus !== chart.id) return false
+            if (window.handlerInFocus !== chart.id || window.textBoxFocused) return false
             if (searchWindow.style.display === 'none') {
                 if (/^[a-zA-Z0-9]$/.test(event.key)) {
                     searchWindow.style.display = 'flex';

src/general/legend.ts

@@ -209,6 +209,7 @@ export class Legend {
             else {
                 data = param.seriesData.get(e.series) as LineData
             }
+            if (!data?.value) return;
             let price;
             if (e.series.seriesType() == 'Histogram') {
                 price = this.shorthandFormat(data.value)

src/general/topbar.ts

@@ -84,7 +84,11 @@ export class TopBar {
             textBox.classList.add('topbar-textbox-input');
             textBox.value = text
             textBox.style.width = `${(textBox.value.length+2)}ch`
+            textBox.addEventListener('focus', () => {
+                window.textBoxFocused = true;
+            })
             textBox.addEventListener('input', (e) => {
+                e.preventDefault();
                 textBox.style.width = `${(textBox.value.length+2)}ch`;
             });
             textBox.addEventListener('keydown', (e) => {
@@ -95,6 +99,7 @@ export class TopBar {
             });
             textBox.addEventListener('blur', () => {
                 window.callbackFunction(`${callbackName}_~_${textBox.value}`)
+                window.textBoxFocused = false;
             });
             this.appendWidget(textBox, align, true)
             return textBox